Depends on what ecomony is like on the releam on what professions make money. My rogue on Icecrown has tailoring/herblism and braz has Enchanting/Skinning. This works out well since I make green items and higher for him to disenchant. Herblism can be a real money maker. Alchemy and Enchanting both use herbs. A stack of Kingsblood(20) can go for 7gold. There are some herbs only rogues use and they usually sell in 10 mins. I tried leather working on my rogue and I couldn't keep up with the levels of her armor. Depending on what you are using the profession for, ie if you are trying to make your money for training and a mount then check the AH to see what stuff is going for. So far what I have seen on CC, stuff is cheaper then Icecrown but that could be because I am level 11 You can also make some decent money fishing but you will have to ask Braz about that.